Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruler length to 280 characters #391

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update ruler length to 280 characters #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f8fb80b
update ruler length to 280 characters per twitter change
atoponce Dec 29, 2017
7b1fa0f
update etc/t-completion.zsh for 140->280 character change
atoponce Apr 13, 2018
a19d880
update ruler length to 280 characters per twitter change
atoponce Dec 29, 2017
b858d09
Merge pull request #1 from atoponce/pr
atoponce Apr 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion etc/t-completion.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ _t (){
"retweet[Sends Tweets to your followers.]" \
"retweets[Returns the 20 most recent Retweets by a user.]" \
"retweets_of_me[Returns the 20 most recent Tweets of the authenticated user that have been retweeted by others.]" \
"ruler[Prints a 140-character ruler]" \
"ruler[Prints a 280-character ruler]" \
"status[Retrieves detailed information about a Tweet.]" \
"timeline[Returns the 20 most recent Tweets posted by a user.]" \
"trends[Returns the top 50 trending topics.]" \
Expand Down
4 changes: 2 additions & 2 deletions lib/t/cli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,10 +688,10 @@ def retweets_of_me
end
map %w(retweetsofme) => :retweets_of_me

desc 'ruler', 'Prints a 140-character ruler'
desc 'ruler', 'Prints a 280-character ruler'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update the reference to this in etc/t-completion.zsh — see the diff in #389. This and #389 are dupes of each other, but each one is missing a piece that the other has, so whichever of you is the first to update is probably the PR that should go ¯\_(ツ)_/¯

method_option 'indent', aliases: '-i', type: :numeric, default: 0, desc: 'The number of spaces to print before the ruler.'
def ruler
markings = '----|'.chars.cycle.take(140).join
markings = '----|'.chars.cycle.take(280).join
say "#{' ' * options['indent'].to_i}#{markings}"
end

Expand Down