Block the request to issue new tokens if an invalid provider is given. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quest is missing the provider param when requesting to issue new tokens.
sfelix-martins
requested changes
Sep 1, 2018
There was a problem hiding this comment.
@Alymosul Firstly, thanks for your contribution. Just check the review comments and update to able the merge.
| } | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
@Alymosul Has an error here. If you pass a provider that not found on config('auth.guards') the OAuthServerException should be thrown. But returning false the provider don't will be invalid.
There was a problem hiding this comment.
Yeah! I missed that, i'll fix it.
…add more tests to cover the null & missing provider cases.
sfelix-martins
approved these changes
Sep 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an early protection in the AddCustomProvider middleware by checking that the provider given in the request is registered in the auth configuration, if not it will throw an exception to block the request also if the request is missing the provider param it will block it.