feat: Add new order clusters endpoint and enhance contract state filtering #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances contract management by adding state filtering capabilities and a new endpoint for retrieving clusters associated with orders.
- Added
--stateoption tocontracts listcommand with validation for "active", "upcoming", or "expired" values insrc/lib/contracts/index.tsx - Modified
listContractsfunction to accept a state parameter and pass it to the API instead of filtering client-side - Added new endpoint
/v0/orders/{id}/clustersinsrc/schema.tsfor retrieving clusters associated with a specific order - Enhanced contract objects with a
statefield throughout the schema with values "Upcoming", "Expired", or "Active" - Added
statequery parameter to/v0/contractsendpoint for server-side filtering
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+71
to
+74
| const state = showAll | ||
| ? "all" | ||
| : (stateFilter?.toLowerCase() as "expired" | "active" | "upcoming") || | ||
| undefined; |
There was a problem hiding this comment.
style: The state logic could be simplified. If showAll is true, it should override any state filter, but the current implementation still allows both parameters to be used together which might be confusing.
| */ | ||
| start_at: string; | ||
| /** | ||
| * Format: date-time | ||
| * @description The time at which the grid should stop placing new orders automatically. Must be on the hour. For sell grids, will be set to the given time (if any) or the end of the backing contract, whichever is sooner. This is not to be confused for the end time of the last order in the grid, i.e. `grid_front + num_orders * order.duration`. | ||
| * @description The time at which the grid should stop placing new orders automatically. The grid never places an order whos (compute-available) end time is after this time. For sell grids, will be set to the given time (if any) or the end of the backing contract, whichever is sooner. This is not to be confused for the end time of the last order in the grid, i.e. `grid_front + num_orders * order.duration`. |
There was a problem hiding this comment.
syntax: There's a typo in the description - "whos" should be "whose" when referring to the order's end time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.