-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unit conversion in sf orders ls
#73
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Fixed unit conversion issues in the OrderDisplay component for the sf orders ls
command, focusing on accurate price calculations and display.
- Fixed calculation of
executedPriceDollarsPerGPUHour
in/src/lib/orders/OrderDisplay.tsx
by properly converting cents to dollars - Added null/undefined checks for
execution_price
to prevent calculation errors - Improved variable naming from
executedPricePerGPUHour
toexecutedPriceDollarsPerGPUHour
for clarity - Added proper price display formatting in OrderMinimal component when execution price is present
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with nits
No description provided.