Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit conversion in sf orders ls #73

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Conversation

Sladuca
Copy link
Contributor

@Sladuca Sladuca commented Feb 17, 2025

No description provided.

Copy link

semanticdiff-com bot commented Feb 17, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  package.json  100% smaller
  src/lib/orders/OrderDisplay.tsx  0% smaller

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Fixed unit conversion issues in the OrderDisplay component for the sf orders ls command, focusing on accurate price calculations and display.

  • Fixed calculation of executedPriceDollarsPerGPUHour in /src/lib/orders/OrderDisplay.tsx by properly converting cents to dollars
  • Added null/undefined checks for execution_price to prevent calculation errors
  • Improved variable naming from executedPricePerGPUHour to executedPriceDollarsPerGPUHour for clarity
  • Added proper price display formatting in OrderMinimal component when execution price is present

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@sigmachirality sigmachirality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with nits

@Sladuca Sladuca merged commit 4636c17 into main Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants