Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix san mateo data #791

Merged
merged 2 commits into from
Jan 4, 2021
Merged

Fix san mateo data #791

merged 2 commits into from
Jan 4, 2021

Conversation

kbrdsk
Copy link
Collaborator

@kbrdsk kbrdsk commented Dec 31, 2020

For issue#764

The data in data/data.json after 9/23 looks faulty, it's consistently displaying 0 cases/deaths which is causing problems in the rendering as well.

This can be fixed by setting and earlier start date for the graph data and forcing some behavior on cumulative cases/deaths but I don't know if that's the desired fix.

Screenshot from 2020-12-30 22-14-43
Screenshot from 2020-12-30 22-14-56

@kengoy kengoy self-requested a review January 4, 2021 04:36
Copy link
Collaborator

@kengoy kengoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbrdsk Thank you for your contribution. The original San Mateo data still does not contain proper number after 9/23 but at least rendering issue is fixed with this. Approved the fix and merge it into master.

@kengoy kengoy merged commit 195ae7e into sfbrigade:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants