Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating streamlit app updates #8

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Integrating streamlit app updates #8

merged 2 commits into from
Sep 23, 2024

Conversation

katiefg
Copy link
Contributor

@katiefg katiefg commented Sep 7, 2024

Description

Updated files in streamlit_app including app.py, the_map.py, requirements.txt within streamlit_app directory, and data files for experimentation with the streamlit app concept. Only files in streamlit_app are impacted by this merge.

Type of changes

  • New Feature (exploratory streamlit app concept)

Testing

  • I did not add automated testing

How to test

-Install requirements.txt
-From streamlit_app/archive/streamlit_app_concept, run streamlit run app.py
-Enter an address into the search bar, press "enter", see whether information is provided and accurate

Copy link
Collaborator

@oscarsyu oscarsyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really awesome work thank you for putting this together! It's definitely better than anything I've put together in streamlit from a technical standpoint so its super cool to see how you went about designing this.

I think there's some valuable visualization ideas that you should share with the team, if you haven't done so already. And i like the concepts for some of the analytics you've pulled.

Hopefully the team has filled you in on this, but the streamlit app was something I just threw together as a concept and won't be the actual thing we launch. I do, however, think it's a valuable place to test out ideas and interactivity. Feel free to keep developing it (and I can help too), or just experiment with visualizations and analytics through jupyter notebooks as well.

Here's maybe some feedback overall:

  • a bit of a nit, but the show function is pretty long and ideally we'd want to break it into pieces. but also, this should not be a prioritiy at all here

maybe more importantly:

  • I think the visualizations are great, especially the animations and counts of soft story statuses.
  • It does look a little busy and I think it might be better if we can go with an approach where we can filter and plot addresses as dots since this craiglist style interface is probably better for searching from a neighborhood level but not great for searching on a address level.
  • the way the layerying on the map to me is a little busy and difficult to quickly read over it. perhaps in the final mock up, we want to only enable 1 or 2 tsunami, or liquification zone layers at a time to avoid overplotting
  • im wondering if the color coding approach you've taken that groups things up by green, orange, or yellow might be better done on a neighborhood level, eg: Duboce Triangle is all "green" instead of grouping into a number count.

overall though, take this feedback as suggestions and great work. really impressive and appreciate hopping on and contributing so quickly!

@oscarsyu
Copy link
Collaborator

oscarsyu commented Sep 9, 2024

i'll also mention, when i tried plotting everything on the map, i ran into major performance issues, so we would need a way to get around that.

@mackcooper1408 mackcooper1408 removed their request for review September 21, 2024 01:58
@oscarsyu oscarsyu merged commit f4b19ee into master Sep 23, 2024
@oscarsyu oscarsyu deleted the KG/dataexplore branch September 23, 2024 04:40
agennadi pushed a commit that referenced this pull request Oct 18, 2024
Integrating streamlit app updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants