Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#126 Add share functionality #133

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

amnak613
Copy link
Collaborator

@amnak613 amnak613 commented Dec 24, 2024

Description

add a short description

  • This PR add the feature of being able to share the report on different addresses through Email, Twitter, Facebook, and as a link.
  • for facebook I found that share does not work on insecure links
    -- once we have a secure url it will share the correct data on facebook

The way I implemented the solution will work when we change to a secure production server

reference to relevant issue
#126

Type of changes

  • Bugfix
  • Chore
  • New Feature

Testing

  • I added automated tests
  • I think tests are unnecessary

How to test

  • Go to app search address and click share link and select method to share the link - IE Email, X, facebook, or by link
    testing description here: i.e. run app, go to x page, see that it does y

@amnak613 amnak613 self-assigned this Dec 24, 2024
@amnak613
Copy link
Collaborator Author

@AdamFinkle ESLint seems to be failing due to my use of ``
is there a way to format the code automatically or this this not allowed?

@amnak613
Copy link
Collaborator Author

@AdamFinkle ESLint seems to be failing due to my use of `` is there a way to format the code automatically or this this not allowed?

was able to fix after using code formatter

@amnak613 amnak613 requested a review from nickvisut January 9, 2025 01:16
Copy link
Collaborator

@nickvisut nickvisut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! good job.

app/components/share.tsx Outdated Show resolved Hide resolved
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
datasci-earthquake ❌ Failed (Inspect) Jan 10, 2025 0:16am

@nickvisut
Copy link
Collaborator

Looks like Vercel deployments are blocking the pull requests. I'll prioritize fixing the build.

Copy link

vercel bot commented Jan 9, 2025

Deployment failed with the following error:

Preview deployments are disabled for this project.

Copy link
Collaborator

@mantuok mantuok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than a small spelling typo everything looks good to me.

app/components/share.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants