-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#126 Add share functionality #133
base: master
Are you sure you want to change the base?
Conversation
@AdamFinkle ESLint seems to be failing due to my use of `` |
was able to fix after using code formatter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! good job.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks like Vercel deployments are blocking the pull requests. I'll prioritize fixing the build. |
Deployment failed with the following error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a small spelling typo everything looks good to me.
Description
add a short description
-- once we have a secure url it will share the correct data on facebook
The way I implemented the solution will work when we change to a secure production server
reference to relevant issue
#126
Type of changes
Testing
How to test
testing description here: i.e. run app, go to x page, see that it does y