Add to_sql for bytes Cow as well #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbaxter
changed the title
sfackler
reviewed
Jul 20, 2023
postgres-types/src/lib.rs
Outdated
| @@ -1035,6 +1035,18 @@ impl<T: ToSql> ToSql for Box<[T]> { | |||
| to_sql_checked!(); | |||
| } | |||
|
|
|||
| impl<'a> ToSql for Cow<'a, [u8]> { | |||
| fn to_sql(&self, ty: &Type, w: &mut BytesMut) -> Result<IsNull, Box<dyn Error + Sync + Send>> { | |||
| <&str as ToSql>::to_sql(&self.as_ref(), ty, w) | |||
There was a problem hiding this comment.
str -> [u8], and you shouldn't need the .as_ref().
There was a problem hiding this comment.
Ah yeah, sorry, was just testing it locally. I'll fix that now!
There was a problem hiding this comment.
Without as_ref I get
error[E0308]: mismatched types
--> postgres-types/src/lib.rs:1040:34
|
1040 | <&[u8] as ToSql>::to_sql(&self, ty, w)
| ------------------------ ^^^^^ expected `&&[u8]`, found `&&Cow<'_, [u8]>`
| |
| arguments to this function are incorrect
|
= note: expected reference `&&[u8]`
found reference `&&Cow<'a, [u8]>`
note: method defined here
--> postgres-types/src/lib.rs:851:8
|
851 | fn to_sql(&self, ty: &Type, out: &mut BytesMut) -> Result<IsNull, Box<dyn Error + Sync + Send>>
| ^^^^^^
There was a problem hiding this comment.
The str thing was fixed, I think this is ready to go. And thanks for the fast review!
There was a problem hiding this comment.
Oh yeah, you'd need to do the same &&**self dance you can see above. This works as well though.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.