wire through knob for TCP user timeout #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this setting exist in psql? I would prefer to mirror its configuration options. |
|
It should! It's one of the libpq params: https://www.postgresql.org/docs/15/libpq-connect.html#LIBPQ-PARAMKEYWORDS |
|
Oh nice, I totally missed that somehow... |
sfackler
reviewed
Mar 25, 2023
|
Thanks! |
|
🙇 thank you @sfackler! |
(It's new in v12, so you might've been looking at an old version of the docs.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCP user timeouts are pretty useful, especially in conjunction with the existing connect timeout / keepalive settings. This adds a new config value, allowing us to set a user timeout on the socket similar to the keepalive setting.