Re-lower the MSRV to 1.48 #1808
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Clippy failures are addressed by #1807 |
alex
force-pushed
the
msrv
branch
7 times, most recently
from
603225f to
fde45cb
Compare
|
The no-op bssl-sys crate from crates.io has a 2021 edition, I've reached out to the maintainer to see about lowering that. |
sfackler
reviewed
Feb 3, 2023
| fail-fast: false | ||
| matrix: | ||
| # Current MSRV and expected next MSRV | ||
| RUST: ["1.48.0", "1.56.0"] |
There was a problem hiding this comment.
Is 1.56 actually an expected next MSRV? that was IIRC just the one that one of those dependency minor versions required. I don't think it was any more intentional than that.
There was a problem hiding this comment.
It's pyca/cryptography's next expected MSRV (based on our usage numbers). So we'd be happy with that reality :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.