Compat release for 1.1.1 #1001
Closed
Compat release for 1.1.1 #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishitatsuyuki
force-pushed
the
0.9.x
branch
from
074655b to
256fd7e
Compare
ishitatsuyuki
force-pushed
the
0.9.x
branch
from
256fd7e to
3b73dda
Compare
|
@sfackler Do you think this code is good enough to merge? I've ensured that the tests passes, but I'm not completely confident that this won't glitch up in production. |
|
The 0.9 release is no longer supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pardon the poor code quality, I didn't really test this. Though, OpenSSL 1.1.1 is binary and API compatible with 1.1.0 so I expect things to pass. I added CI configurations to test if this stands.