-
-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error while building app #2184
Comments
It looks like you've hit the same issue as #2179, which appears to be caused by an issue with the cc crate, although you might be able to workaround it by disabling the parallel feature. It might be worth raising this with cc directly (if it hasn't been done already). |
but rust-openssl is the one using cc as a dependency, I think it is also in their benefit to contact the developers of cc crate? I checked and I have the impression the cc developers are already working in a solution |
Yeah ok looks like this will be fixed by rust-lang/cc-rs#962 |
cc 1.0.87 has released which shall fix this. |
@Masber can you check that this has fixed the issue for you. I can't see why it wouldn't but best to check. |
Tuning in here because we also had one of our builds crash as well after bumping the openssl dependency (src) |
I checked the commit triggering the build and I see that both cc and openssl(-src) is bumped. That's strange because cc 1.0.87 should fix that by only setting Original: |
It could be the reason why the failure still happens in sfackler/rust-openssl#2184 (comment)
@ohsayan can you try rust-lang/cc-rs#973 to see if it fixes your issue? |
OpenSSL fails to build on macOS due to issues with parallel builds. Context: - sfackler/rust-openssl#2184 - rust-lang/cc-rs#973
@NobodyXu Reverted dependency updates to openssl-* and cc as well. Builds are passing with this change. |
This comment has been minimized.
This comment has been minimized.
I got absolutely no idea why it fails. I checked the openssl-src, it doesn't call Build::compile anywhere so cc won't even try to build jobserver, let alone setting |
Tested separately. As soon as I bump OpenSSL, the build fails (see this workflow run). The only change that was made: - openssl = { version = "0.10.63", features = ["vendored"] }
+ openssl = { version = "0.10.64", features = ["vendored"] } and after a [[package]]
name = "cc"
- version = "1.0.83"
+ version = "1.0.87" |
Can you test rust-lang/cc#975 please? It should finally fix the bug. |
This comment was marked as resolved.
This comment was marked as resolved.
@ohsayan I'm not sure if specify a git dependency in your project works, I think you might need to use patch.crates-io instead. checking your Cargo.lock, you got two cc, one is 1.0.87, another is git version of it. |
@NobodyXu my bad, I'll use an override (patch) and see. I'll get back to you in a moment. |
@NobodyXu confirming that this change indeed fixes the build |
cc 1.0.88 has released! |
Users of my CLI have just also reported and I confirmed that I still see this error even though I have cc v1.0.88 (only one) and openssl-sys v0.9.101. Here is the command to reproduce:
|
This error is still occurring for mv on |
It could be the reason why the failure still happens in sfackler/rust-openssl#2184 (comment)
This error still occurred for me on |
The last few comments suggest to me this is resolved, I'm on a little bit of a spring clean so I'm going to say thank you to @NobodyXu and close this. If this isn't resolved for some reason feel free to re-open/comment. |
Dear rust-openssl community,
I have a github pipeline to build the artifacts of my application, for some reason the pipeline fails when building the binaries for the apple target.
and
Full pipeline output can be seen here https://github.com/eth-cscs/manta/actions/runs/8004159748/job/21860989556#step:8:607
Any advice?
thank you very much
The text was updated successfully, but these errors were encountered: