Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crate_id should specify different filename #1

Closed
lilyball opened this issue Dec 29, 2013 · 2 comments
Closed

crate_id should specify different filename #1

lilyball opened this issue Dec 29, 2013 · 2 comments

Comments

@lilyball
Copy link
Contributor

The crate_id right now is "github.com/sfackler/rust-openssl". This means the resulting filename is librust-openssl-4fdb0f34-0.0.dylib. This also means that in order to reference this crate, you need to say something like

extern mod openssl = "rust-openssl";

because rust-openssl is not a valid identifier.

I would recommend that the library name be changed to just "openssl", but modifying the crate_id to

#[crate_id="github.com/sfackler/rust-openssl#openssl:0.0"];

You may also want to pick a non-0.0 version number as well.

@sfackler
Copy link
Owner

I was holding off on this until rust-lang/rust#11086 goes through since it'll make it unbuildable with rustpkg.

@sfackler
Copy link
Owner

The crate should use the name openssl now.

avadacatavra pushed a commit to avadacatavra/rust-openssl that referenced this issue Jul 12, 2017
created bogo build scripts and moved shim to examples
shanecurran added a commit to shanecurran/rust-openssl that referenced this issue Mar 3, 2021
…tificate to make the Rust implementation match the OpenSSL spec.

Included warning documentation on Bleichenbacher's attack on PKCS sfackler#1 v1.5 RSA padding
CfirTsabari pushed a commit to CfirTsabari/rust-openssl that referenced this issue Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants