Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update native-tls version to 0.2 #18

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Update native-tls version to 0.2 #18

merged 2 commits into from
Sep 17, 2018

Conversation

lunaryone
Copy link
Contributor

No description provided.

@sfackler
Copy link
Owner

This doesn't appear to compile.

@lunaryone
Copy link
Contributor Author

Build completed successfully with latest stable rustc 1.29
Tests are passed successfully

@est31
Copy link

est31 commented Sep 17, 2018

The build failure is due to one of the dependencies having started to require >1.17 Rust. According to travis, compilation works on stable.

@est31
Copy link

est31 commented Sep 17, 2018

One thing I'm not sure about though is the removal of the public method... it means that this PR constitutes a semver breaking change. Is there some way to avoid that?

@lunaryone
Copy link
Contributor Author

The new implementation of TlsConnector (native-tls 2.1) has no method danger_connect_without_providing_domain_for_certificate_verification_and_server_name_indicatio

All configuration of the TlsConnector should be done in TlsConnectorBuilder.
I see no ways to avoid breaking changes
The old functionality is still accessible via custom TlsConnector and method from

@sfackler
Copy link
Owner

This upgrade is a breaking change no matter what the API surface looks like - native-tls is a public dependency of this crate.

@lunaryone
Copy link
Contributor Author

@sfackler Could you please clarify what do you expect from my side?

@sfackler
Copy link
Owner

Let's bump the minimum supported Rust version to fix the build, and then I'll cut an 0.3 release.

@lunaryone
Copy link
Contributor Author

The minimum supported version to build it is 1.21

@sfackler
Copy link
Owner

This should be good to go with a rebase.

@lunaryone lunaryone closed this Sep 17, 2018
@lunaryone lunaryone reopened this Sep 17, 2018
@sfackler sfackler merged commit b37cf71 into sfackler:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants