-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update native-tls version to 0.2 #18
Conversation
This doesn't appear to compile. |
Build completed successfully with latest stable rustc 1.29 |
The build failure is due to one of the dependencies having started to require >1.17 Rust. According to travis, compilation works on stable. |
One thing I'm not sure about though is the removal of the public method... it means that this PR constitutes a semver breaking change. Is there some way to avoid that? |
The new implementation of TlsConnector (native-tls 2.1) has no method danger_connect_without_providing_domain_for_certificate_verification_and_server_name_indicatio All configuration of the TlsConnector should be done in TlsConnectorBuilder. |
This upgrade is a breaking change no matter what the API surface looks like - native-tls is a public dependency of this crate. |
@sfackler Could you please clarify what do you expect from my side? |
Let's bump the minimum supported Rust version to fix the build, and then I'll cut an 0.3 release. |
The minimum supported version to build it is 1.21 |
This should be good to go with a rebase. |
No description provided.