use prone to retrieve better frames #10
Conversation
|
Hey @piranha this looks good. Are you still interested in getting this merged? @sethtrain was so kind to add me as a collaborator so I would be able to merge this. I wonder if it would make sense to add some tests? Or do you think the important bits are already tested in the prone tests? |
|
I'm not exactly sure what to test, to be honest. Prone tests itself well, so yeah, not sure if it's necessary. |
|
That's totally fine too, was just a thought :) Thanks for updating the PR 👍 |
|
This is now released as |
|
Ugh, just spotted a mistake, will release 1.4.1 shortly. |
|
Ok, 1.4.1 released with actual dependency on Prone. Please report any bugs. |
| :exception [{:stacktrace (make-stacktrace-info (.getStackTrace e) app-namespaces) | ||
| :type (str (class e)) | ||
| :value (.getMessage e)}])) | ||
| (let [stacks (stacks/normalize-exception (stack/root-cause e)) |
There was a problem hiding this comment.
Where is root-cause coming from here?
There was a problem hiding this comment.
is it just clojure.stacktrace/root-cause?
|
|
No description provided.