Add basic subpixel AA text support on Linux. #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
approved these changes
Nov 4, 2016
|
Re: gamma correction. I've elaborated some of my thoughts in #230. |
glennw
force-pushed
the
subpixel
branch
3 times, most recently
from
293294b to
dd2f5fb
Compare
Merged
|
r? @pcwalton |
pcwalton
reviewed
Nov 7, 2016
| BlendMode::Alpha | ||
| } else { | ||
| BlendMode::None | ||
| } |
There was a problem hiding this comment.
nit: could be
_ if needs_blending => BlendMode::Alpha,
_ => BlendMode::None
Up to you
There was a problem hiding this comment.
I've left as is for now - will tidy up when I expand this function today for a different PR.
| @@ -215,6 +217,9 @@ impl FontContext { | |||
| } | |||
| } | |||
| FT_PIXEL_MODE_LCD => { | |||
| // Extra subpixel on each side of the glyph. | |||
| glyph_width += 2; | |||
|
|
|||
There was a problem hiding this comment.
Ugly. :( Oh well, probably can't be helped.
| @@ -92,6 +92,7 @@ const GPU_TAG_PRIM_BORDER: GpuProfileTag = GpuProfileTag { label: "Border", colo | |||
| pub enum BlendMode { | |||
| None, | |||
| Alpha, | |||
| Subpixel(ColorF), | |||
There was a problem hiding this comment.
Could you add a comment saying that the ColorF is the color of the text?
This is some preliminary support for subpixel AA. Specifically: * Only on Linux for now. * No gamma correction. * Disabled by default (use -Z subpixel-aa to test). * Doesn't deal with rotations, subpixel positioning etc.
|
@bors-servo r=pcwalton (irc) |
|
📌 Commit bab4731 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 7, 2016
Add basic subpixel AA text support on Linux. This is some preliminary support for subpixel AA. Specifically: * Only on Linux for now. * No gamma correction. * Disabled by default (use -Z subpixel-aa to test). * Doesn't deal with rotations, subpixel positioning etc. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/527) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some preliminary support for subpixel AA. Specifically:
This change is