Fail initialization if the max texture size is insufficient. #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nical
force-pushed
the
min-max-texture-size
branch
from
35e8ebd to
8f6cfb3
Compare
|
Moved this sanity check to the beginning of the function to not bother with creating shaders, threads and other resources. r? @kvark |
|
Thanks, looking good! |
|
📌 Commit 8f6cfb3 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 9, 2017
Fail initialization if the max texture size is insufficient. This works around #1260 ([driver issues entry](https://github.com/servo/webrender/wiki/Driver-issues#1260---broken-gl-context-reports-max-texture-size-equal-to-zero)) by gracefully failing the initialization instead of panicking the first time we try to allocate a texture cache page. This should let us fallback to another compositor backend and more easily identify the issue when it happens.
|
💔 Test failed - status-travis |
|
@nical y u no compile? :)
|
nical
force-pushed
the
min-max-texture-size
branch
from
8f6cfb3 to
6e82302
Compare
|
oops, did a last minute change and apparently forgot to build it. This version does build locally now. |
|
@bors-servo r=kvark,glennw |
|
📌 Commit 6e82302 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 9, 2017
Fail initialization if the max texture size is insufficient. This works around #1260 ([driver issues entry](https://github.com/servo/webrender/wiki/Driver-issues#1260---broken-gl-context-reports-max-texture-size-equal-to-zero)) by gracefully failing the initialization instead of panicking the first time we try to allocate a texture cache page. This should let us fallback to another compositor backend and more easily identify the issue when it happens.
|
☀️ Test successful - status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around #1260 (driver issues entry) by gracefully failing the initialization instead of panicking the first time we try to allocate a texture cache page.
This should let us fallback to another compositor backend and more easily identify the issue when it happens.