Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to fork of debug_unreachable #206

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented Jun 3, 2018

Because the original debug_unreachable is abandoned and doesn't work correctly in modern Rust.


This change is Reviewable

@KiChjang
Copy link
Contributor

KiChjang commented Jun 3, 2018

Is the repository located here https://github.com/mbrubeck/rust-debug-unreachable ? Because the one at crates.io redirects back to reem's repo and not yours, and I don't seem to see any code changes in your fork.

@mbrubeck
Copy link
Contributor Author

mbrubeck commented Jun 3, 2018

Yes, that's the repository. The code for the fork is in the fork branch. I've updated the repo link on crates.io.

Because the original debug_unreachable is abandoned and doesn't work correctly in modern Rust.
@mbrubeck mbrubeck force-pushed the debug_unreachable branch from ee3f73a to 007c826 Compare June 3, 2018 16:03
@KiChjang
Copy link
Contributor

KiChjang commented Jun 4, 2018

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 007c826 has been approved by KiChjang

@bors-servo
Copy link
Contributor

⌛ Testing commit 007c826 with merge e838e1c...

bors-servo pushed a commit that referenced this pull request Jun 4, 2018
Switch to fork of debug_unreachable

Because the original debug_unreachable is abandoned and doesn't work correctly in modern Rust.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/string-cache/206)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: KiChjang
Pushing e838e1c to master...

@bors-servo bors-servo merged commit 007c826 into servo:master Jun 4, 2018
@mbrubeck
Copy link
Contributor Author

mbrubeck commented Jun 5, 2018

Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants