Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rustc 1.3.0-dev (e4e93196e 2015-07-14) #6737

Closed
wants to merge 2 commits into from
Closed

Upgrade to rustc 1.3.0-dev (e4e93196e 2015-07-14) #6737

wants to merge 2 commits into from

Conversation

SimonSapin
Copy link
Member

This gets us the [&str]::connect to join renaming, which matters because string_cache_plugin uses #![deny(warnings)] and rust-lang/rust#27259 is not here yet.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 24, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5643

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@mbrubeck
Copy link
Contributor

Reviewed 4 of 4 files at r1, 7 of 7 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io

@SimonSapin
Copy link
Member Author

Maybe wait for e10s to land before this. CC @pcwalton

@metajack metajack added S-awaiting-answer Someone asked a question that requires an answer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 29, 2015
@metajack
Copy link
Contributor

@pcwalton Do you want a rust up landed? It should probably be easy enough to update this rustup to include the drop flag partial removal.

@metajack
Copy link
Contributor

Is this superceded by #6850?

@mbrubeck
Copy link
Contributor

Is this superceded by #6850?

Yes.

@mbrubeck mbrubeck closed this Jul 30, 2015
@mbrubeck mbrubeck removed the S-awaiting-answer Someone asked a question that requires an answer. label Jul 30, 2015
@SimonSapin SimonSapin deleted the rustup_2015-07-14 branch July 30, 2015 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SimonSapin @hoppipolla-critic-bot @mbrubeck @metajack @highfive