Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Use Heap for typed arrays. #15672

Closed
wants to merge 1 commit into from
Closed

[WIP] Use Heap for typed arrays. #15672

wants to merge 1 commit into from

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Feb 21, 2017 •
edited by larsbergstrom
Loading

Depends on servo/rust-mozjs#341.

This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/textdecoder.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/vrframedata.rs, components/script/dom/crypto.rs, components/script/dom/imagedata.rs, components/script/dom/bindings/trace.rs, components/script/dom/vrstageparameters.rs, components/script/dom/vrpose.rs
  • @fitzgen: components/script/dom/textdecoder.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/vrframedata.rs, components/script/dom/crypto.rs, components/script/dom/imagedata.rs, components/script/dom/bindings/trace.rs, components/script/dom/vrstageparameters.rs, components/script/dom/vrpose.rs
  • @emilio: components/script/dom/webglrenderingcontext.rs

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Feb 21, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify script code, but no tests are modified. Please consider adding a test!

@jdm jdm added the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Feb 21, 2017
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #15653) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Feb 21, 2017
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Feb 21, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 65170ff with merge f9ce207...

bors-servo pushed a commit that referenced this pull request Feb 21, 2017
Auto merge of #15672 - servo:typed-arrays-heap, r=<try>
f9ce207 
Use Heap for typed arrays.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15672)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-wpt

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Feb 21, 2017
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #15715) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Feb 24, 2017
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Feb 27, 2017
nox
nox reviewed Mar 3, 2017
View reviewed changes
Cargo.lock Outdated
@@ -1281,7 +1281,7 @@ dependencies = [
[[package]]
name = "js"
version = "0.1.4"
source = "git+https://github.com/servo/rust-mozjs#101c6b6b58e0b7c5ed1ef2b6b676a7497f90df2f"
source = "git+https://github.com/servo/rust-mozjs#25d3ec54c67883aa0a561f5a2f2e485280d113a1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to tip or to the merge commit of the corresponding PR and r=me.

@nox nox assigned nox and unassigned mbrubeck Mar 3, 2017
@nox nox added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. S-needs-rebase There are merge conflict errors. labels Mar 3, 2017
@jdm
Copy link
Member

jdm commented Mar 3, 2017

Pretty sure the try push from last time demonstrated some fundamental problems with using RootedTraceableBox for this, since that doesn't actually root nursery-allocated objects.

@Ms2ger Ms2ger force-pushed the typed-arrays-heap branch from c471c3a to 65599bd Compare March 14, 2017 15:18
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Mar 14, 2017
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 14, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 65599bd with merge 57bdd32...

bors-servo pushed a commit that referenced this pull request Mar 14, 2017
Auto merge of #15672 - servo:typed-arrays-heap, r=<try>
57bdd32 
Use Heap for typed arrays.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15672)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-dev-unit

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Mar 14, 2017
@nox
Copy link
Contributor

nox commented Mar 14, 2017

http://build.servo.org/builders/linux-rel-wpt/builds/2858

@Ms2ger Ms2ger force-pushed the typed-arrays-heap branch from 65599bd to cebd476 Compare March 14, 2017 16:30
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Mar 14, 2017
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 14, 2017

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit cebd476 with merge 7188751...

bors-servo pushed a commit that referenced this pull request Mar 14, 2017
Auto merge of #15672 - servo:typed-arrays-heap, r=<try>
7188751 
Use Heap for typed arrays.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15672)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - windows-msvc-dev

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Mar 14, 2017
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 14, 2017

Doh.

@bors-servo try

@Ms2ger Ms2ger force-pushed the typed-arrays-heap branch from cebd476 to 10cdee2 Compare March 14, 2017 17:26
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Mar 14, 2017
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Mar 14, 2017

For real.

@bors-servo try

@bors-servo
Copy link
Contributor

⌛ Trying commit 10cdee2 with merge 9199bb5...

bors-servo pushed a commit that referenced this pull request Mar 14, 2017
Auto merge of #15672 - servo:typed-arrays-heap, r=<try>
9199bb5 
Use Heap for typed arrays.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15672)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - linux-rel-css

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label Mar 14, 2017
@KiChjang
Copy link
Contributor 

Tests with unexpected results:
  ▶ PASS [expected FAIL] /compositing-1_dev/html/mix-blend-mode-animation.htm

Is this a good thing?

@Ms2ger Ms2ger changed the title Use Heap for typed arrays. [WIP] Use Heap for typed arrays. Mar 16, 2017
@Ms2ger Ms2ger force-pushed the typed-arrays-heap branch from 10cdee2 to 35a38f3 Compare March 16, 2017 14:01
@highfive highfive removed the S-tests-failed The changes caused existing tests to fail. label Mar 16, 2017
@Ms2ger Ms2ger added the S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. label Mar 16, 2017
@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #16210) made this pull request unmergeable. Please resolve the merge conflicts.

@highfive highfive added the S-needs-rebase There are merge conflict errors. label Apr 1, 2017
@jdm jdm mentioned this pull request Nov 15, 2017
Closed
@jdm
Copy link
Member

jdm commented Nov 15, 2017

Closing due to inactivity. Tracking in #19241.

@jdm jdm closed this Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nox nox nox left review comments

Assignees

@nox nox

Labels
S-awaiting-review There is new code that needs to be reviewed. S-blocked-on-external Something, somewhere else, needs to happen before this PR can be merged. S-needs-rebase There are merge conflict errors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Ms2ger @highfive @bors-servo @jdm @nox @KiChjang @mbrubeck