New modifications #155

c410-f3r · 2019-06-15T18:14:12Z

Fixes #154 and some other things.

Adds the alloc feature and doesn't remove the std feature because of std::io::Write.
Replaces mem::uninitialized with MaybeUninit.
Uses NonNull<T> instead of *mut T.
Removes deprecated VecLike.
Uses core::hint::unreachable_unchecked instead of unchecked.
Splits bloated lib.rs file into smaller modules for better readability, localization and maintainability.
Bumps minimum compiler version to 1.36.
Uses the new 2018 ~~epoch~~ version.
Adds new scripts for testing in development and CI.

This change is

jdm · 2019-06-15T18:23:10Z

Could you please redo these changes so there's a separate commit for each of the points you mentioned? This is really difficult to review in its current condition.

c410-f3r · 2019-06-15T18:26:41Z

@jdm Sure

lib.rs: Alloc feature Cargo.toml: New features and 2018 edition

For testing in development and CI

Method names are now matching std

mbrubeck · 2019-06-19T16:43:23Z

lib.rs

@@ -258,25 +258,25 @@ impl<A: Array> SmallVecData<A> {
    #[inline]
    unsafe fn inline(&self) -> &A {
        match *self {
-            SmallVecData::Inline(ref a) => a,
+            SmallVecData::Inline(ref a) => &*a.as_ptr(),


I believe it's unsound to return an &A that points to a possibly-uninitialized A. This method should be changed to return a raw pointer. (The callers of this method only need raw pointers anyways.)

mbrubeck · 2019-06-19T16:43:25Z

lib.rs

            _ => debug_unreachable!(),
        }
    }
    #[inline]
    unsafe fn inline_mut(&mut self) -> &mut A {
        match *self {
-            SmallVecData::Inline(ref mut a) => a,
+            SmallVecData::Inline(ref mut a) => &mut *a.as_mut_ptr(),


Like inline above, this method should be changed to return a raw pointer.

c410-f3r · 2019-06-19T19:43:29Z

Thanks @mbrubeck

c410-f3r · 2019-07-04T14:52:43Z

1.36 was released and Travis now checks all variants of Rust.

Can I squash commits?

jdm · 2019-07-04T15:05:10Z

@SimonSapin How does this work relate to #157?

SimonSapin · 2019-07-04T15:08:13Z

I haven’t looked at the diff, but based on the description a lot of it is similar or equivalent. Only with a different approach: incremental changes v.s. rewrite.

c410-f3r · 2019-07-04T15:11:53Z

Based on this current work, I can apply @SimonSapin modifications in future PRs

c410-f3r · 2019-07-08T17:11:50Z

The const_generics feature is now fully functional. Is anything preventing this PR from being merged?

SimonSapin · 2019-07-08T18:35:30Z

While experimenting with const generics in a branch is fine, I would prefer not to have them in the master branch or on a crates.io release of this crate, at this time.

Constant generics are now fully working.

I realize this is not exactly what you meant, but that’s an overstatement.

Using #![feature(const_generics)] makes current nigthlies print warning: the feature `const_generics` is incomplete and may cause the compiler to crash. As far as I know this kind of warning is unprecedented in Rust. smallvec’s tests might be passing with const generic now, but there is no telling whether it’ll regress in a future Nightly.

c410-f3r · 2019-07-08T19:49:14Z

I realize this is not exactly what you meant, but that’s an overstatement.

I am sorry for the misunderstanding. Early versions of this PR contained a non-functional implementation for constant generics and it is now properly fixed.

As far as I know this kind of warning is unprecedented in Rust. smallvec’s tests might be passing with const generic now, but there is no telling whether it’ll regress in a future Nightly.

It is the own nature of unstable Rustc features to break existing code in future releases, the same reason can be applied to already included unstable features of smallvec. If CI testing is a concern, a dedicated job that is allowed to fail can be included.
The current code is structured in a way that no constant generic stuff is invoked without explicitly telling otherwise by setting the feature, therefore, everything on stable will work without problems.

Nevertheless, if you guys feel comfortable enough to merge this code without constant generics, I can extract it into a separate PR.

c410-f3r · 2019-07-31T12:06:46Z

Constant generics inside macros has been fixed in Make generic parameters always use modern hygiene rust-lang/rust#63083.
The job for Rust nightly in CI is now allowed to fail.

bors-servo · 2019-08-10T16:07:02Z

☔ The latest upstream changes (presumably #159) made this pull request unmergeable. Please resolve the merge conflicts.

emilio · 2019-10-19T03:04:26Z

I think most of this stuff has landed already incrementally... Should this be closed?

emilio · 2019-10-19T03:05:48Z

(Like, constant generics and other improvements are still welcome I guess, but this PR as is is pretty unlikely to land)

mbrubeck · 2019-10-28T23:59:39Z

I cherry-picked and landed some of the changes from this that weren't covered by other PRs. I'm closing this now but feel free to open new PRs for any remaining changes. Smaller, incremental patches are appreciated if possible.

Thanks!

c410-f3r force-pushed the master branch 2 times, most recently from c2acd16 to 0865b42 Compare June 15, 2019 18:21

c410-f3r force-pushed the master branch 2 times, most recently from aa1a49c to a797f80 Compare June 15, 2019 18:26

Modifies lib.rs and Cargo.toml

9534a6b

lib.rs: Alloc feature Cargo.toml: New features and 2018 edition

c410-f3r force-pushed the master branch from a797f80 to c574a43 Compare June 16, 2019 01:49

c410-f3r added 10 commits June 15, 2019 22:57

Removes the VecLike struct

0b90d21

New scripts for testing

8de1d3b

For testing in development and CI

Updates the Travis.yml file

93f9909

Modifies the Array trait

4e70e25

Method names are now matching std

Do not use the no_std feature

c109e5c

Make use of NonNull

7f73f8a

Make use of MaybeUninit

e1bb097

Rustfmt

d3a6c9c

Splits the lib.rs file

ef7c328

Make use of core::hint::unreachable_unchecked

85440ce

c410-f3r force-pushed the master branch from c574a43 to 776ce5c Compare June 16, 2019 01:59

c410-f3r added 2 commits June 16, 2019 07:50

Adds the const_generics feature

94b2383

Adjust documentation

2063374

c410-f3r force-pushed the master branch from 93380af to 2063374 Compare June 16, 2019 10:51

mbrubeck reviewed Jun 19, 2019

View reviewed changes

c410-f3r added 2 commits June 19, 2019 16:14

Clippy

557c4c7

Return a pointer in inline and inline_mut

950e3e3

c410-f3r added 3 commits July 4, 2019 11:24

Enable 1.36 on Travis

d7b2352

Re-enable no_std

90dcc25

Enable all-features on docs.rs

cd02cd3

Fix some constant generics errors

4cc4d37

Fix modified tests there were using String

4b2e32c

c410-f3r added 2 commits July 4, 2019 12:32

Do not use const_generics feature on docs.rs

7aea556

Make constant generics work

7538698

c410-f3r mentioned this pull request Jul 10, 2019

Support for constant generics bluss/arrayvec#125

Closed

c410-f3r added 2 commits July 31, 2019 08:56

Macro hygiene for constant generics has been fixed

9fed114

Allow failures in nightly

a61da16

mbrubeck mentioned this pull request Oct 28, 2019

Use NonNull instead of a raw pointer #171

Merged

mbrubeck closed this Oct 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New modifications #155

New modifications #155

c410-f3r commented Jun 15, 2019 •

edited

Loading

jdm commented Jun 15, 2019

c410-f3r commented Jun 15, 2019

mbrubeck Jun 19, 2019

mbrubeck Jun 19, 2019

c410-f3r commented Jun 19, 2019

c410-f3r commented Jul 4, 2019

jdm commented Jul 4, 2019

SimonSapin commented Jul 4, 2019

c410-f3r commented Jul 4, 2019 •

edited

Loading

c410-f3r commented Jul 8, 2019 •

edited

Loading

SimonSapin commented Jul 8, 2019 •

edited

Loading

c410-f3r commented Jul 8, 2019 •

edited

Loading

c410-f3r commented Jul 31, 2019 •

edited

Loading

bors-servo commented Aug 10, 2019

emilio commented Oct 19, 2019

emilio commented Oct 19, 2019

mbrubeck commented Oct 28, 2019

New modifications #155

New modifications #155

Conversation

c410-f3r commented Jun 15, 2019 • edited Loading

jdm commented Jun 15, 2019

c410-f3r commented Jun 15, 2019

mbrubeck Jun 19, 2019

Choose a reason for hiding this comment

mbrubeck Jun 19, 2019

Choose a reason for hiding this comment

c410-f3r commented Jun 19, 2019

c410-f3r commented Jul 4, 2019

jdm commented Jul 4, 2019

SimonSapin commented Jul 4, 2019

c410-f3r commented Jul 4, 2019 • edited Loading

c410-f3r commented Jul 8, 2019 • edited Loading

SimonSapin commented Jul 8, 2019 • edited Loading

c410-f3r commented Jul 8, 2019 • edited Loading

c410-f3r commented Jul 31, 2019 • edited Loading

bors-servo commented Aug 10, 2019

emilio commented Oct 19, 2019

emilio commented Oct 19, 2019

mbrubeck commented Oct 28, 2019

c410-f3r commented Jun 15, 2019 •

edited

Loading

c410-f3r commented Jul 4, 2019 •

edited

Loading

c410-f3r commented Jul 8, 2019 •

edited

Loading

SimonSapin commented Jul 8, 2019 •

edited

Loading

c410-f3r commented Jul 8, 2019 •

edited

Loading

c410-f3r commented Jul 31, 2019 •

edited

Loading