Never run ragel when generated files exist #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jdm |
jdm
requested changes
Nov 18, 2019
| @@ -308,7 +308,7 @@ EXTRA_DIST += \ | |||
| $(NULL) | |||
| # We decided to add ragel-generated files to git... | |||
| #MAINTAINERCLEANFILES += $(RAGEL_GENERATED) | |||
| $(srcdir)/%.hh: $(srcdir)/%.rl | |||
| $(srcdir)/%.hh: | |||
There was a problem hiding this comment.
If we apply this change, we need some way to preserve this when we update harfbuzz to new releases, which happens fairly regularly.
|
Rather than changing an in-tree makefile, let's update https://github.com/servo/rust-harfbuzz/blob/master/harfbuzz-sys/makefile.touch with the hh files instead. |
SimonSapin
force-pushed
the
ragelless
branch
from
65cb8a0 to
129e6b7
Compare
|
@bors-servo r+ |
|
📌 Commit 129e6b7 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 18, 2019
Never run ragel when generated files exist This is untested, but hopefully works around servo/servo#24611. This is not suitable for development of Harfbuzz itself (as opposed to bindings), but hopefully that doesn’t happen in this repository and being required to run `cargo clean` after updating the Harfbuzz version is acceptable.
|
☀️ Test successful - checks-travis |
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Nov 18, 2019
… to pick up servo/rust-harfbuzz#173, which hopefully fixes #24611
SimonSapin
added a commit
to servo/servo
that referenced
this pull request
Nov 18, 2019
… to pick up servo/rust-harfbuzz#173, which hopefully fixes #24611
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Nov 18, 2019
Update harfbuzz-sys … to pick up servo/rust-harfbuzz#173, which hopefully fixes #24611
|
This is another thing that would be fixed by PR #170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested, but hopefully works around servo/servo#24611.
This is not suitable for development of Harfbuzz itself (as opposed to bindings), but hopefully that doesn’t happen in this repository and being required to run
cargo cleanafter updating the Harfbuzz version is acceptable.