-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring, better ability to use cssparser-color
as a separate crate.
#377
Conversation
Apparently part of the changes were also requested here: #376 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of these look good but can we avoid the breaking changes in cssparser? Seem unnecessary to me unless I'm missing something.
@emilio That's absolutely doable, it's just that I see valid reasoning in the |
Yeah, the tokenizer uses the It'd also mean we'd have to rewrite quite a few callers. That's not a huge deal if the improvement is clear, but for me at least In any case, those changes should probably be their own PR. I'd prefer to split the different high-level changes in different PRs if that's possible, so that they can be reviewed / merged independently. |
I see, sure thing! I'll revert the naming and version changes as soon as possible. |
Okay, that should be it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great, but the commit history is a bit of a mess. I sent #378 with it cleaned-up.
cssparser-color
separation:Access to private implementation items for parsers and other software using the crate.
My own project. I use the crate to serialize and deserialize CSS3-compatible color data from user input and config files. This was impossible without these changes.
color
crate items are gated by a newserde
feature in the inner crate.clippy
- caused a semantic conflict with std'sIterator
.All checks passed on my fork, but I'm not familiar with the guidelines for commits for this repository. It's my first one here. I hope it's up to expectations. 😁
If something's up, be sure to comment.