Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the documentation of what certain parse functions return #372

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

tiaanl
Copy link
Collaborator

@tiaanl tiaanl commented Mar 22, 2024

Issue mentioned in #281

Copy link
Contributor

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine so far, though #281 probably includes changing these docstrings, as well?

/// Return `Ok((A, B))`, or `Err(())` for a syntax error.

/// This method returns `Err(())` the first time that a closure call does,

/// or `Err(())` to ignore the entire declaration as invalid.

/// or `Err(())` to ignore the entire at-rule as invalid.

/// or `Err(())` to ignore the entire at-rule as invalid.

/// or `Err(())` to ignore the entire at-rule as invalid.

/// or `Err(())` to ignore the entire at-rule as invalid.

/// `RuleListParser` is an iterator that yields `Ok(_)` for a rule or `Err(())` for an invalid one.

Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thisi s a strict improvement.

@emilio emilio added this pull request to the merge queue Apr 6, 2024
Merged via the queue into main with commit d44a7cc Apr 6, 2024
11 checks passed
@tiaanl tiaanl deleted the update-return-err-doc branch April 6, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants