Upgrade to SpiderMonkey 67 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows build doesn't find a viable llvm-config. |
|
Oh joy... https://travis-ci.com/servo/mozjs/jobs/208965905#L2085 |
|
Apart from the travis failure, this all looks sensible. We should edit the git history to make the version bump the last commit. |
|
The travis failure will be fixed by #188. |
|
@bors-servo r=asajeffrey |
|
📌 Commit 220ffbe has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 26, 2019
Upgrade to SpiderMonkey 67 <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/mozjs/186) <!-- Reviewable:end -->
|
💔 Test failed - checks-travis |
|
I'm retrying the failed jobs individually. |
|
☀️ Test successful - checks-travis, status-appveyor |
bors-servo
pushed a commit
to servo/rust-mozjs
that referenced
this pull request
Jun 26, 2019
Upgrade to SpiderMonkey 67 Depends on servo/mozjs#186. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-mozjs/465) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is