This repository has been archived by the owner on Mar 20, 2024. It is now read-only.
forked from barosl/homu
-
Notifications
You must be signed in to change notification settings - Fork 48
Permissions checks broken on master #150
Comments
@pietroalbini Oh, my bad. Thanks for pointing the problem out. I'll create a PR reintroducing the |
@pietroalbini I have created this PR that should solve the problem. #151 |
bors-servo
pushed a commit
that referenced
this issue
Mar 20, 2018
Fix auth in parse_commands As discussed in #150, the auth shouldn't' be done at the beginning of `parse_commands`, but when some action is going to be executed. This PR reintroduces `functools.partial` to fix the issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/151) <!-- Reviewable:end -->
Thank you so much! |
yshui
pushed a commit
to hadeaninc/homu
that referenced
this issue
Apr 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
After updating bors to the latest master in the rust-lang/rust repository, we saw a few problems:
I think the cause of that is #149. Before that PR, the
verify_auth
calls were "configured" at the start ofprocess_command
and then called when they were actually needed. Instead, now theverify_auth
calls are directly executed at the start ofprocess_command
, which means bors check if the user is a reviewer even if they send a simple comment without any command.The simple solution to this issue is to reintroduce
functools.partial
in auth checks.cc @alexrs @jdm @alexcrichton
The text was updated successfully, but these errors were encountered: