This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Update to Rust 1.15.0-nightly (ac635aa95 2016-11-18) #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Am scared: rust-lang/rust#37786 |
Manishearth
reviewed
Nov 15, 2016
@@ -66,8 +64,6 @@ fn expand_string(input: &str) -> String { | |||
} | |||
|
|||
let tokens = quote! { | |||
#type_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a decorator now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
r=me if stuff works |
SimonSapin
reviewed
Nov 15, 2016
@@ -96,7 +92,7 @@ fn test_struct() { | |||
$e, expanded) | |||
} | |||
} | |||
match_count!("struct Foo<T> { bar: Bar, baz: T, z: Arc<T> }", 1); | |||
match_count!("struct Foo<T> { bar: Bar, baz: T, z: Arc<T> }", 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is now testing absence, change the string to just "struct"
.
@bors-servo r+ |
📌 Commit 916d7dc has been approved by |
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Nov 20, 2016
Update to Rust 1.15.0-nightly (ac635aa95 2016-11-18)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.