Allow creating fonts with Arc<dyn AsRef[u8] + Send + Sync>
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has advantages over a simple `Arc<Vec<u8>>` because it can avoid data copies. A common case that this happens is when Servo creates fonts from shared memory. In addition, this maintains full compatability with `Arc<Vec<u8>>` because it fulfills the trait. Finally, this bumps the version so that the changes can be deployed. Signed-off-by: Martin Robinson <[email protected]>
jdm
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has advantages over a simple
Arc<Vec<u8>>because it can avoiddata copies. A common case that this happens is when Servo creates
fonts from shared memory. In addition, this maintains full compatability
with
Arc<Vec<u8>>because it fulfills the trait.Finally, this bumps the version so that the changes can be deployed.