Add some bindings to the private CGSRegion APIs.

[pcwalton]

These enable us to tell the window server about the opaque regions of
the window so that it can perform occlusion culling.

See https://github.com/NUIKit/CGSInternal/blob/master/CGSRegion.h

r? @metajack

---

This change is

[metajack]

This looks fine, but had a question on the return value. r=me if that doesn't matter.

Previously, pcwalton (Patrick Walton) wrote…

Add some bindings to the private CGSRegion APIs.

These enable us to tell the window server about the opaque regions of

the window so that it can perform occlusion culling.

See https://github.com/NUIKit/CGSInternal/blob/master/CGSRegion.h

r? @metajack

---

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

src/private.rs, line 34 [r1] (raw file):

        unsafe {
            let mut region = ptr::null_mut();
            ffi::CGSNewRegionWithRect(rect, &mut region);

Is checking the status unimportant?

---

src/private.rs, line 45 [r1] (raw file):

    use geometry::CGRect;

    enum CGSRegionObject {}

It doesn't much matter, but why an empty enum instead of an empty struct?

---

Comments from Reviewable

[pcwalton]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

src/private.rs, line 45 [r1] (raw file):

Previously, metajack (Jack Moffitt) wrote…

It doesn't much matter, but why an empty enum instead of an empty struct?

So that you can't create a value of `CGSRegionObject` (without unsafe code and a lot of magic).

---

Comments from Reviewable

[metajack]

Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

src/private.rs, line 45 [r1] (raw file):

Previously, pcwalton (Patrick Walton) wrote…

So that you can't create a value of CGSRegionObject (without unsafe code and a lot of magic).

That would make a nice comment.

---

Comments from Reviewable

[pcwalton]

Updated. r? @metajack

[metajack]

Add the comment, squash, and r=me.

Previously, pcwalton (Patrick Walton) wrote…

Updated. r? @metajack

---

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[pcwalton]

@bors-servo: r=metajack

[bors-servo]

📌 Commit 3c37274 has been approved by metajack

[bors-servo]

⌛ Testing commit 3c37274 with merge 8be09b1...

[bors-servo]

☀️ Test successful - travis