Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few typo from DSL #902

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

yzhao244
Copy link
Contributor

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

What this PR does:

This PR contains a few typo fix for DSL doc

Additional information:

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a little comment, looks great to me! Thanks @yzhao244 ❤️

dsl.md Show resolved Hide resolved
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked the anchors and they are good and indeed in another file.

Thanks and welcome back :)

@ricardozanini
Copy link
Member

@yzhao244 can you please sign your commit?

@yzhao244
Copy link
Contributor Author

@yzhao244 can you please sign your commit?

right, will do that. :)

Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cdavernas
Copy link
Member

DCO is still failling. Don't forget to sign-off your commits.

@yzhao244 yzhao244 force-pushed the yuri-dev-1.0.0-typo branch from d505e14 to b5bacb0 Compare June 24, 2024 18:00
@yzhao244
Copy link
Contributor Author

DCO is still failling. Don't forget to sign-off your commits.

DCO is still failling. Don't forget to sign-off your commits.

DCO is still failling. Don't forget to sign-off your commits.

DCO is still failling. Don't forget to sign-off your commits.

DCO is still failling. Don't forget to sign-off your commits.

oh sorry, let me fix my commit. :)

Signed-off-by: Yuri Zhao <[email protected]>
@yzhao244 yzhao244 force-pushed the yuri-dev-1.0.0-typo branch from b5bacb0 to 7ad569d Compare June 24, 2024 19:09
@yzhao244
Copy link
Contributor Author

Fixed my PR, now has one signed off commit. :)

@ricardozanini ricardozanini merged commit ffcf80b into serverlessworkflow:main Jun 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants