-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a few typo from DSL #902
a few typo from DSL #902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a little comment, looks great to me! Thanks @yzhao244 ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked the anchors and they are good and indeed in another file.
Thanks and welcome back :)
@yzhao244 can you please sign your commit? |
right, will do that. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
DCO is still failling. Don't forget to sign-off your commits. |
d505e14
to
b5bacb0
Compare
oh sorry, let me fix my commit. :) |
Signed-off-by: Yuri Zhao <[email protected]>
b5bacb0
to
7ad569d
Compare
Fixed my PR, now has one signed off commit. :) |
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
This PR contains a few typo fix for DSL doc
Additional information: