-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #1071] Until option if any is empty #1072
Conversation
Fix serverlessworkflow#1071 Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask you to update this sample by removing the now useless until: '${ false }'
condition?
@cdavernas If no until, I guess the assumption (according to ther examples where any is not empty and there is no unitil) is to move forward when any event is received (in other words, no until is equivalent to |
@fjtirado Not as far as I understand it. If you define an empty |
@cdavernas I prefer this because is aligned with the behaviour of other examples where there is at least one filter in the any array and there is no until. In those examples, once the expected event arrive, it moves forwards to next task. I think it should be the same when it is listening to all events. |
Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
Co-authored-by: Charles d'Avernas <[email protected]> Signed-off-by: Francisco Javier Tirado Sarti <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cheers man! ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much easier to implement now! I'll remove the workarounds from the Go SDK hehehe
Fix #1071
Please specify parts of this PR update:
Discussion or Issue link:
What this PR does:
Additional information: