Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution for issue 27. Updated dependencies, fixed typescript error in index.d.ts file. #44

Closed
wants to merge 1 commit into from

Conversation

JustFly1984
Copy link

I've fixed types declaration for #27

Please review and publish new version.

@fredericbarthelet
Copy link
Contributor

Hi @JustFly1984 and thanks for your contribution :)

Please note that, as stated in the Contribution guildelines, any modification made to the index.d.ts definition file of this repository is useless - the purpose of this repository is to generate those definition automatically from JSON schema validation constraints within the Serverless Framework. Your modifications would be removed on the next version release.

In order to generate valid types with the additionalProperties key of JSON Schema, an improvement shall be made on json-schema-to-ts library. You can help by contributing on bcherny/json-schema-to-typescript#356 (comment)

Closing this in the meantime. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants