Add CacheControl headers on the OPTIONS response in AWS API Gateway #5328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #5326
How did you implement it:
Added a conditional check when cacheControl property is present on a cors property for a function, it will add the value as the header for the response. This was only built for AWS API Gateway.
How can we verify it:
I have modified https://github.com/serverless/examples/tree/master/aws-node-simple-http-endpoint example to include the cors change. The cacheControl property is the only new thing that I added.
sample serverless.yml
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO