Update handler name when deploy a single function #5301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
In this PR I fixed an issue (or a not implemented feature), according the function handler name of an AWS Lambda, while deploying a single function. (using
deploy -f / --function
)Former to that fix, when deploying a single function even if you change the code and the handler file / handler method , changing the handler name in the
serverless.yml
was not affected.(BTW other configuration such as memorySize, description, timeout, etc.. are affected as expected)
Closes #XXXXX
How did you implement it:
As done for others configuration ( such as memorySize, description, timeout, etc..)
while
updateFunctionConfiguration() {...}
in /lib/plugins/aws/deployFunction/index.js - I did implement the same logic to take the handler name from the functionObj and added it to params of thecallUpdateFunctionConfiguration
methodHow can we verify it:
serverless.yml
(e.g to point on an other method)-f
/--function
cmd line option.Todos:
Is this ready for review?: YES
Is it a breaking change?: NO