fix unable to run function in other namespaces

[arditdine]

I had this issue that I could invoke functions only in the default namespace, if I deploy in other namespaces it will fail to be invoked
I noticed that when you create a new serverless project with the command:
serverless create --template kubeless-nodejs --path new-project works fine, you can deploy in every namespace and can invoke the functions.
If you check in package.json it uses serverless-kubeless v0.4.0. I've tested and everything works fine up to version 0.6.0
In the new versions of serverless-kubeless it doesn't work. The only difference I found between versions was that in invoke.js on line 115 the function was changed from core.services.get => core.ns.services.get
If you remove ns it works fine again.

[andresmgot]

Thanks for the PR @arditdine ! I have a suggestion for a more suitable solution. Let me know if you can give it a try.

[andresmgot]

this should be core.ns since that's the configured namespace. The issue is in line 83. connectionOptions is not taking the namespace into account. To fix it replace:

-      const connectionOptions = helpers.getConnectionOptions(helpers.loadKubeConfig());
+      const connectionOptions = helpers.getConnectionOptions(helpers.loadKubeConfig(), {
+        namespace,
+      });

[arditdine]

Yes, tested this solution and it's working well. I've updated the PR as well

[andresmgot]

Thanks @arditdine! The code now looks good to me but you need to adapt the tests. There are a couple of them failing due to these changes:

      1) calls the API end point with the correct namespace (in the provider)
      2) calls the API end point with the correct namespace (in the function)

https://travis-ci.org/github/serverless/serverless-kubeless/builds/753492408#L391

You can find the test at test/kubelessInvoke.test.js.

Also, can you bump the version of the package? (So it gets automatically released when merging this PR).

[arditdine]

Sorry didn't notice the tests but I can fix them. Just a quick question about version bump. Should I bump the minor or the patch?

[andresmgot]

The patch version, since we are fixing a bug

[andresmgot]

Thanks!