New waitForDeployment check logic #215
Conversation
lib/helpers.js
Outdated
| function setExponentialInterval(cb, initialDelay, maxDelay) { | ||
| let delay = initialDelay; | ||
| let timer; | ||
| const internalCb = () => { |
There was a problem hiding this comment.
The naming cb internalCb is not that readable, I would use something more meaningful like targetFunction and timerWrapper.
Also, initialDelay doesn't seem like a very useful parameter now (it was more important before to calculate the total delay). Can we remove it?
There was a problem hiding this comment.
I agree: targetFunction and timerWrapper are a lot better than cb and internalCb 👍
About initialDelay (and maxDelay) parameters: the setExponentialInterval could be a multipurpose util function. This is the reason I added the two parameters. It's something like the original setInterval but with an exponential behaviour.
Anyway, If you prefer I can remove the two parameters ;)
There was a problem hiding this comment.
yes, I didn't mean to delete the two parameters to control the interval, just the one for the initialDelay since it's less useful than maxDelay. In any case, having both doesn't hurt.
|
Thank for merging @andresmgot! |
|
That's a bit annoying, the tests are not that reliable. For example, in this branch, the test that failed was the one that deployes a scheduled function: https://travis-ci.org/github/serverless/serverless-kubeless/builds/718959671#L772 But in master, a unit test failed: https://travis-ci.org/github/serverless/serverless-kubeless/builds/719211821#L337 Unfortunately, I don't know what can be causing this flakiness (and I don't have that much time to allocate for this). Will release the version manually, thanks for the heads up. |
This pull request replace the current setInterval implementation with an exponential check (30 seconds of max check delay).
This type of check permits a longer wait period without flooding the kubernetes master.
A longer wait period is required for service with a considerable number of functions and with a runtime that needs a build step (.net, java, ...).