Fix transient dependency version and add more tests for aiohttp #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've described the exact problem on yarl repo aio-libs/yarl#854 (comment) |
selcukcihan
changed the title
|
@medikoo ready for review please 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on https://linear.app/serverless/issue/SC-905/python-sdk-incorrect-span-hierarchy I've noticed that the integration test
aiohttp_requesterwas failing. I've noticed it fails against main as well. I could not trace it to a particular change we had. So I started looking at the dependencies.I've traced the issue to a release in one of dependencies of
aiohttp, namedyarl. That repo has an issue that look similar to the problem we are facing: aio-libs/yarl#854The problem is,
urlreported in the tracing callbacks https://docs.aiohttp.org/en/stable/tracing_reference.html lack the query string parameter.This PR adds a unit test that reproduces this problem
, fix is yet to be provided.fix is provided as well.For reference, if we install
yarl==1.8.2the tests pass (previous version). If we use the latest versionyarl==1.9.1the tests fail https://pypi.org/project/yarl/#historyTesting done
Unit/integration tested