Fix packaging for non-node functions #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0k3r
approved these changes
Jun 10, 2021
Also: - remove useless `console.log` - add a test to cover an exception when container image is badly defined - run format command
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes: --
Continuation of #808
This PR will make it so all non-node runtimes are ignored.
How did you implement it:
Replaced instances of this.serverless.service.getAllFunctions with a new util function that filters and returns only node functions.
How can we verify it:
Unit tests are added and updated:
Can be tested with any config that include other runtimes like python,java etc.
Todos:
Is this ready for review?: Yes
Is it a breaking change?: NO