Fix configuration check for keepoutputdirectory in cleanup #748
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #747
Appears to be that the cleanup function no longer checks the configuration, only
this.keepOutputDirectory
which appears to be a flag set by other processesHow did you implement it:
I added a check for the configuration passing a
keepOutputDirectory
flag as well in the cleanup module.How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO