Feat/concurrency #680
Closed
Feat/concurrency #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add copyExistingArtifacts to packageModules * Refactor packageModules * Set service path * Generate artifact name from service * Output artifacts to .webpack before copying * Set artifact name for service packaging * Skip webpack:compile if --no-build is set * Add webpack:package:copyExistingArtifacts hook * Make packageModules & packExternalModules no-op if skipCompile is set * Refactor packageModules * Remove artifact location setting from packageModules * Update cleanup to check this.keepOutputDirectory * Fix path join on Windows Co-authored-by: Miguel A. Calles MBA <[email protected]>
Use `.map(..., { concurrency })` instead of `.mapSeries(...)`
… serverless.yml. Left only number conversion, since CLI options are typed as string
|
Shall I rebase and PR to |
7 tasks
|
@miguel-a-calles-mba Did exactly that in #681, closing this one in favor of that. Thanks for the reply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Supersedes #517, adding concurrency support for more than one thread.
How did you implement it:
Please see #517 (comment), basically I did two changes:
serizliedCompile: Booleanwithconcurrency: NumberserializedCompile: truetoconcurrency: 1for backward compatibilityHow can we verify it:
Use the config below when packaging:
Todos:
Is this ready for review?: Yes
Is it a breaking change?: No