Don't package non-node functions (fix for #644) #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase against the master? Thanks! |
|
Also, could you add some tests to cover your changes? |
j0k3r
reviewed
Feb 2, 2021
Yes, I've been looking at the unit tests to figure out where to put it and what to check (as I would have expected the existing unit tests to fail, but they aren't). I think I've got that figured out, so I will try and get that in today. |
|
Ok, I added a new function to the testFunctionsConfig. Without my fix in there, I get five failures. With my fix, all the tests pass. |
…heaven#644 Also fixed a typo in one of the names of the tests
This was referenced Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Most of serverless-webpack already deals with not packaging non-node functions. There is only one section that is still problematic. This fix deals with the issue where a runtime may be defined for an individual function or for a provider. It will default to a runtime of "nodejs" if no runtime is specified at either the function or provider level.
Closes #644
How did you implement it:
When processing the async config, implemented an extra step before mapping the functions to filter out functions that don't have a node runtime.
How can we verify it:
Add a function (in my case it was a Rust function) that uses a non-node runtime and the app should still package correctly.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO