Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to exclude files using regular expression #612

Merged
merged 2 commits into from
Jul 26, 2020

Conversation

j0k3r
Copy link
Member

@j0k3r j0k3r commented Jul 24, 2020

Superseded #552 because we got no answer from OP.

What did you implement:

Exclude files from zip using regular expression

How did you implement it:

Added new param to configuration, create a conditional to filter the files array if param exists

How can we verify it:

add options excludeRegex: .ts to configuration
check zip file for .ts files

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@j0k3r j0k3r added this to the 5.4.0 milestone Jul 24, 2020
@j0k3r j0k3r changed the base branch from master to release/5.4.0 July 24, 2020 09:29
@j0k3r j0k3r force-pushed the feature/exclude-regex branch from 49efbd1 to c0e3639 Compare July 24, 2020 09:30
@j0k3r
Copy link
Member Author

j0k3r commented Jul 24, 2020

I force pushed to rebase against the release/5.4.0 branch

@j0k3r j0k3r force-pushed the feature/exclude-regex branch from c0e3639 to 12e393d Compare July 24, 2020 09:31
@j0k3r j0k3r force-pushed the feature/exclude-regex branch from 12e393d to 1c11afa Compare July 24, 2020 09:32
@j0k3r j0k3r force-pushed the feature/exclude-regex branch from 1c11afa to 467decd Compare July 24, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants