Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Empty lines while stats: 'errors-only' #500

Merged
merged 1 commit into from
May 20, 2019

Conversation

Enase
Copy link

@Enase Enase commented May 10, 2019

What did you implement:

Closes #499

How did you implement it:

Do not print empty console messages in case if compiled item stats return nothing.

How can we verify it:

Setup webpack config with stats: 'errors-only' and run serverless deploy

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

PS:

It's very simple change that makes logs much more readable

Copy link
Member

@HyperBrain HyperBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition

@HyperBrain HyperBrain added this to the 5.3.1 milestone May 20, 2019
@HyperBrain HyperBrain merged commit f6fba80 into serverless-heaven:master May 20, 2019
@Enase Enase deleted the empty-lines branch July 23, 2019 10:41
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
Fix: Empty lines while stats: 'errors-only'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty lines while stats: 'errors-only'
2 participants