Adds the ability to specify an excludeFiles glob #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Do not remove any section of the template. If something is not applicable leave it empty but leave it in the PR 2. Please follow the template, otherwise we'll have to ask you to update it and it will take longer until your PR is merged --> Closes serverless-heaven#433 <!-- Briefly describe the feature if no issue exists for this PR. If possible only submit PRs for existing issues. If the PR is trivial (like doc changes or simple code fixes) it can be submitted without a related issue, but as soon as it adds or changes functionality, a related issue should be present. --> Fairly trivial, just used the ignore option in glob to exclude files matching the glob. 1. Setup a serverless project with an index.test.js and an index.js that handle a route 2. Start it up and see that you get a warning about duplicate files matching for index 3. Now pull in this PR 4. add the following to your serverless.yml file in the custom > webpack section `excludeFiles: **/*.test.js` 5. restart serverless 6. see that the warnings are now gone! - [x] Write tests - [ ] Write documentation - [x] Fix linting errors - [x] Make sure code coverage hasn't dropped - [x] Provide verification config / commands / resources - [x] Enable "Allow edits from maintainers" for this PR - [x] Update the messages below ***Is this ready for review?:*** YES ***Is it a breaking change?:*** NO
|
Looking for suggestions on which section of the documentation notes should be added to... |
|
Added documentation in the best place that I could find |
|
@HyperBrain any thoughts on this? |
|
@HyperBrain this issue looks relatively simple to test and could not introduce breaking changes. |
|
@serverless-heaven/serverless-webpack-team Would love to have someone other than me sign off on this. |
|
Would love to get this merged too 👍 |
7 tasks
|
@designfrontier Will try my best to give it a whirl this week and report back 👍 |
hassankhan
approved these changes
Apr 14, 2019
|
Had a chance to run it against my project, all the errors are now gone 👍 Thanks @designfrontier! |
Merged
|
Released with 5.3.0 |
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
…arning Adds the ability to specify an excludeFiles glob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #433
How did you implement it:
Fairly trivial, just used the ignore option in glob to exclude files matching the glob.
How can we verify it:
excludeFiles: **/*.test.jsTodos:
Is this ready for review?: YES
Is it a breaking change?: NO