Add support for Serverless v4 #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicary
approved these changes
Oct 22, 2024
As of now, we can't jump straight to v4 in dev deps because some tests still require the v3 version (because we are mocking some stuff).
j0k3r
force-pushed
the
feat/serverless-v4
branch
from
dc95103 to
a3bc239
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, we can't jump straight to v4 in dev deps because some tests still require the v3 version (because we are mocking some stuff and the v4 only ship a binary).
The short solution is just to allow
4in peer deps. But we prefer to have a running test that ensure a package is properly generated with deps inside.As we can't use the internal tooling
@serverless/testanymore in v4 (the project might be dead and no tests are running on the v4 official repo 😳, anyway) we are using the binary directly to package the example project. We were forced to use an access key from serverless dashboard and some aws valid credentials. But it now works ✅Fix #1923