Apply promisify()
to fs
module functions to avoid error with Serverless v4
#1917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #1912
How did you implement it:
Instead of relying on some other party applying promisify on
fs
module functions, do it explicitly inside this library. Also, apply promisify in non-mutable way to keepfs
module tidy.This should fix the
fs.readFileAsync is not a function
error when used with serverless v4.How can we verify it:
fs.readFileAsync is not a function
error anymoreTodos:
Is this ready for review?: YES
Is it a breaking change?: NO