When using SLS_DEBUG env var, more log will be dumped

[kennyhyun]

What did you implement:

Related to #1508 and probably #1653 too

How did you implement it:

How can we verify it:

Todos:

• Write tests
• Write documentation
• Fix linting errors
• Make sure code coverage hasn't dropped
• Provide verification config / commands / resources
• Enable "Allow edits from maintainers" for this PR
• Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

[vicary]

@kennyhyun What was the errors you are working with?

Depending on the specific error that is sent to stdout instead of stderr, it could either be

1. An incorrect implementation, or
2. Changing toString() in SpawnError may be a better option instead.

[j0k3r]

@vicary I think it's related to #1508 (comment)

[kennyhyun]

yes @j0k3r thanks

@vicary yeah I tried SpawnError as well but it was not logged.

and SpawnError is an exported function, so I could not imagine the consequences.

if it logs errors, and you guys think SpawnError is better, I can change

Thanks for the quick response!

[kennyhyun]

after reading more, I think npm/yarn packager doesn't log stdout from the SpawnError instance

should I merge stdout into stderr if stderr was empty string or packagers should be updated? I am two minded

---

probably keep this for now

[kennyhyun]

@vicary one of the errors I was dealing with was,

.../@nodert-win10-rs4/windows.storage install$ node-gyp rebuild
../../../../../node_modules/parse-domain postinstall$ run-s build:tries
.../@nodert-win10-rs4/windows.storage install: gyp info it worked if it ends with ok
.../@nodert-win10-rs4/windows.storage install: gyp info using [email protected]
.../@nodert-win10-rs4/windows.storage install: gyp info using [email protected] | linux | x64
.../@nodert-win10-rs4/windows.storage install: gyp info find Python using Python version 3.11.2 found at "/usr/bin/python3"
.../@nodert-win10-rs4/windows.storage install: (node:103869) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
.../@nodert-win10-rs4/windows.storage install: (Use `node --trace-deprecation ...` to show where the warning was created)
.../@nodert-win10-rs4/windows.storage install: gyp info spawn /usr/bin/python3
.../@nodert-win10-rs4/windows.storage install: gyp info spawn args [

which resolved by downgrading python to 3.10

I could log this from stdout, I guess it was from npm, but am sure yarn was the same.

[kennyhyun]

Sorry I cannot reproduce that anymore.

Can I just console.log stdout when SLS_DEBUG was specified instead?

[vicary]

@j0k3r thanks for referencing to the source!

@kennyhyun It's not easy to generalize a solution at the level of spawnProcess. But when we look at npm.js and yarn.js, it's more safer to do stdout + stderr at the respective .catch(). What do you think?

[kennyhyun]

@vicary thanks for the feedback.

yeah I agree, let me do that in npm.js and yarn.js

[j0k3r]

Looks great, you can squash 👍