Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add .js extension to entries values #166

Closed
wants to merge 1 commit into from
Closed

Do not add .js extension to entries values #166

wants to merge 1 commit into from

Conversation

kikar
Copy link
Contributor

@kikar kikar commented Jul 27, 2017

What did you implement:

Closes #165

How did you implement it:

How can we verify it:

Todos:

  • Write tests
  • [] Write documentation
  • Fix linting errors (not yet implemented)
  • Make sure code coverage hasn't dropped (not yet implemented)
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@kikar kikar closed this Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use the new slsw.lib.entries with typescript
1 participant