adding missing optional peer deps #1287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Updated optional peer dependencies to fix warnings
Closes #XXXXX - didn't make a ticket, pretty straight forward.
This screenshot sums up the issue pretty nicely.
yarn link
is using my changes,yarn unlink
is using the version from npm:How did you implement it:
How can we verify it:
If you have a project that's using serverless-webpack typescript, and ts-node, you'll see this warning appear when you install it. If you use my branch instead, the warning goes away.
Todos:
Is this ready for review?: YES
Is it a breaking change?: It shouldn't be. Added two
*
optional peer dependencies and optional peer@typescript@>=2.0
, which was already a requirement of ts-node. I guess if they have typescript 1.X but don't have ts-node it would be breaking? Not sure how you want to classify that. Alternatively, changing it to*
would mean it's definitely non-breaking.