-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yarn workspaces support #1258
Add yarn workspaces support #1258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me!
Great, thanks for your help :) |
I'm waiting for a review from @vicary, in the mean time, I think you can squash our commits :) |
10dc06c
to
a32ceef
Compare
a32ceef
to
7391ff8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a yarn workspace project to test this with, the changes looks fine.
Despite recent activities in GitHub, find-yarn-workspace-root
has no new releases for 2 years. We should keep that in mind if yarn breaks this in 4+.
Did you test if this works with Yarn PnP on Yarn Berry? I was trying to package an external module whilst using Yarn workspaces and PnP. But I get warnings.
|
What did you implement:
Support for yarn workspaces when including external packages.
There were issue with the yarn.lock wich isn't in the project folder but in the yarn workspace root folder.
Closes #XXXXX
How did you implement it:
I added a dependency to get the root path of a yarn workspace. If the project is not a yarn workspaces project it default to the current behavior.
How can we verify it:
I added a e2e test which represente the problem I had : examples/include-external-npm-packages-with-yarn-workspaces/
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO